Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix macOS library suffix for TF 2.12 #2333

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 17, 2023

In TF 2.12, .dylib files was removed from macOS wheels with only .2.dylib left.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit e73d7d8)
@njzjz njzjz mentioned this pull request Feb 17, 2023
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

Codecov Report

Base: 74.71% // Head: 74.75% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (ec25281) compared to base (445f6ba).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2333      +/-   ##
==========================================
+ Coverage   74.71%   74.75%   +0.04%     
==========================================
  Files         223      223              
  Lines       22262    22262              
  Branches     1627     1627              
==========================================
+ Hits        16634    16643       +9     
+ Misses       4575     4565      -10     
- Partials     1053     1054       +1     
Impacted Files Coverage Δ
source/lib/include/ComputeDescriptor.h 79.32% <0.00%> (+0.18%) ⬆️
source/op/descrpt.cc 60.16% <0.00%> (+0.27%) ⬆️
source/lmp/pair_deepmd.cpp 48.12% <0.00%> (+0.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm wanghan-iapcm merged commit e02da2e into deepmodeling:devel Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants