Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source a relative path #2420

Merged
merged 1 commit into from
Mar 23, 2023
Merged

source a relative path #2420

merged 1 commit into from
Mar 23, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Mar 22, 2023

Fix #2409.
By default, source searches the file from PATH (see the help from source --help). This might conflict with other packages. To prevent this behavior, one has to source the relative path instead.

Fix deepmodeling#2409.
By default, `source` searches the file from `PATH` (see the help from `source --help`). This might cause conflict. To prevent this behavior, one has to source the relative path instead.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm March 22, 2023 19:50
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1015473) 75.23% compared to head (712b5f4) 75.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2420   +/-   ##
=======================================
  Coverage   75.23%   75.24%           
=======================================
  Files         223      223           
  Lines       22582    22582           
  Branches     1669     1669           
=======================================
+ Hits        16990    16991    +1     
- Misses       4504     4505    +1     
+ Partials     1088     1086    -2     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit cf33e28 into deepmodeling:devel Mar 23, 2023
nahso pushed a commit to HPC-AI-Team/deepmd-kit-se_atten-models that referenced this pull request Apr 12, 2023
Fix deepmodeling#2409.
By default, `source` searches the file from `PATH` (see the help from
`source --help`). This might conflict with other packages. To prevent
this behavior, one has to source the relative path instead.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants