Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set mixed_type to True for mixed systems #2428

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Mar 24, 2023

When mixed systems training (#2372) is enabled, the mixed_type attribute will affect the data stat.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cf33e28) 75.21% compared to head (f680d14) 75.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2428   +/-   ##
=======================================
  Coverage   75.21%   75.21%           
=======================================
  Files         223      223           
  Lines       22582    22583    +1     
  Branches     1669     1669           
=======================================
+ Hits        16984    16985    +1     
+ Misses       4514     4513    -1     
- Partials     1084     1085    +1     
Impacted Files Coverage Δ
deepmd/descriptor/se_atten.py 94.46% <100.00%> (ø)
deepmd/utils/data_system.py 84.34% <100.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@njzjz njzjz marked this pull request as draft March 24, 2023 23:03
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review March 25, 2023 01:29
@njzjz njzjz requested review from iProzd and wanghan-iapcm March 25, 2023 01:29
@wanghan-iapcm wanghan-iapcm merged commit 8568521 into deepmodeling:devel Mar 25, 2023
nahso pushed a commit to HPC-AI-Team/deepmd-kit-se_atten-models that referenced this pull request Apr 12, 2023
When mixed systems training (deepmodeling#2372) is enabled, the mixed_type attribute
will affect the data stat.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants