remove _GLIBCXX_USE_CXX11_ABI macro for libraries linking against the C library #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… C library The libraries linking against the C library do not need to use the same `_GLIBCXX_USE_CXX11_ABI` as the TF. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## devel #2527 +/- ##
==========================================
- Coverage 75.03% 74.99% -0.04%
==========================================
Files 228 228
Lines 23882 23882
Branches 1666 1680 +14
==========================================
- Hits 17919 17910 -9
- Misses 4889 4899 +10
+ Partials 1074 1073 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
build lmp in wheels with _GLIBCXX_USE_CXX11_ABI=0
wanghan-iapcm
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libraries linking against the C library do not need to use the same
_GLIBCXX_USE_CXX11_ABIas the TF.