Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lmp: forward errors to error->one instead of error->all #2539

Merged
merged 1 commit into from
May 19, 2023
Merged

lmp: forward errors to error->one instead of error->all #2539

merged 1 commit into from
May 19, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 18, 2023

Fix #2516.

@njzjz
lmp: forward errors to error->one instead of error->all
a7e8374 
Fix deepmodeling#2516.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz linked an issue May 18, 2023 that may be closed by this pull request
The task should have reported OOM from the beginning, but the task has not been terminated as usual #2516
Closed
@codecov
Copy link

codecov bot commented May 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 5.00% and project coverage change: -0.02 ⚠️

Comparison is base (0b670f8) 74.98% compared to head (a7e8374) 74.96%.

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #2539      +/-   ##
==========================================
- Coverage   74.98%   74.96%   -0.02%     
==========================================
  Files         228      228              
  Lines       23882    23889       +7     
  Branches     1680     1680              
==========================================
+ Hits        17907    17908       +1     
- Misses       4900     4907       +7     
+ Partials     1075     1074       -1
Impacted Files Coverage Δ
source/lmp/fix_dplr.cpp 0.00% <0.00%> (ø)
source/lmp/pair_deepmd.cpp 53.21% <0.00%> (ø)
source/lmp/compute_deeptensor_atom.cpp 91.42% <25.00%> (-2.78%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit 27bc41b into deepmodeling:devel May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

Assignees
No one assigned
Labels
LAMMPS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The task should have reported OOM from the beginning, but the task has not been terminated as usual
2 participants
@njzjz @wanghan-iapcm