Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix se_e3 tabulate op #2552

Merged
merged 2 commits into from
May 22, 2023
Merged

fix se_e3 tabulate op #2552

merged 2 commits into from
May 22, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 22, 2023

Fix #2250.

njzjz added 2 commits May 21, 2023 17:19
@njzjz
fix se_e3 tabulate op
bdcf779 
Fix deepmodeling#2250.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz
move to tearDownModule
d7e4baf 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz linked an issue May 22, 2023 that may be closed by this pull request
A large error induced by compression for se_e3 descriptor #2250
Closed
@njzjz njzjz requested a review from denghuilu May 22, 2023 03:28
@codecov
Copy link

codecov bot commented May 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (5f3bbbc) 75.35% compared to head (d7e4baf) 75.34%.

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #2552      +/-   ##
==========================================
- Coverage   75.35%   75.34%   -0.02%     
==========================================
  Files         227      227              
  Lines       23816    23790      -26     
  Branches     1666     1658       -8     
==========================================
- Hits        17947    17925      -22     
- Misses       4793     4799       +6     
+ Partials     1076     1066      -10
Impacted Files Coverage Δ
source/lib/src/tabulate.cc 54.74% <100.00%> (-0.20%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit 450455f into deepmodeling:devel May 22, 2023
This was referenced May 22, 2023
Closed
Merged
@njzjz njzjz mentioned this pull request Jul 14, 2023
Merged
wanghan-iapcm pushed a commit that referenced this pull request Jul 15, 2023
@njzjz @pre-commit-ci
fix se_atten tabulate when exclude_types is given (#2679)
205023b 
This PR is similar to #2552. Usually, the input to tabulate OP is
sorted, but if `exclude_types` is given, the input will not be sorted
anymore.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@njzjz njzjz mentioned this pull request Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denghuilu denghuilu denghuilu approved these changes

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

Assignees
No one assigned
Labels
Core CUDA Python ROCM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A large error induced by compression for se_e3 descriptor
3 participants
@njzjz @denghuilu @wanghan-iapcm