fix the missing modifier issue of dp compress #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njzjz
approved these changes
Jun 6, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2591 +/- ##
=======================================
Coverage 76.66% 76.66%
=======================================
Files 233 233
Lines 24175 24176 +1
Branches 1697 1711 +14
=======================================
+ Hits 18533 18535 +2
+ Misses 4519 4518 -1
Partials 1123 1123
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current model compression feature will miss data modifier if it is used to compress a dplr model. This PR builds the modifier in the compressing process if there is a modifier in the uncompressed model.