Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: migrate from FindCUDA to CUDA language #2634

Merged
merged 12 commits into from
Jun 26, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jun 25, 2023

FindCUDA will be removed in CMake 3.27, per https://cmake.org/cmake/help/latest/release/3.27.html#deprecated-and-removed-features.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (69d7c01) 78.45% compared to head (b2a7e9e) 78.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2634      +/-   ##
==========================================
- Coverage   78.45%   78.34%   -0.11%     
==========================================
  Files         232      232              
  Lines       24437    24446       +9     
  Branches     1462     1469       +7     
==========================================
- Hits        19171    19152      -19     
- Misses       4876     4904      +28     
  Partials      390      390              

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

njzjz and others added 5 commits June 25, 2023 14:27
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as draft June 25, 2023 19:43
njzjz added 3 commits June 25, 2023 16:17
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review June 25, 2023 21:14
… defined

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm wanghan-iapcm merged commit 0412d34 into deepmodeling:devel Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants