Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise error if both v1 and v2 parameters are given #2714

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 2, 2023

Fix #2656.

Fix deepmodeling#2656.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from iProzd August 2, 2023 20:09
@github-actions github-actions bot added the Python label Aug 2, 2023
@njzjz njzjz linked an issue Aug 2, 2023 that may be closed by this pull request
njzjz and others added 2 commits August 2, 2023 16:12
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (4fa54ec) 78.64% compared to head (ffc5dce) 78.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2714   +/-   ##
=======================================
  Coverage   78.64%   78.65%           
=======================================
  Files         239      239           
  Lines       25465    25467    +2     
  Branches     1517     1517           
=======================================
+ Hits        20028    20031    +3     
- Misses       5045     5046    +1     
+ Partials      392      390    -2     
Files Changed Coverage Δ
deepmd/utils/compat.py 84.31% <50.00%> (-0.46%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit 3e37b59 into deepmodeling:devel Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Strange behavior when set training/systems in input.json
3 participants