Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added atomic dipole to test.py #2747

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

hanao2
Copy link
Contributor

@hanao2 hanao2 commented Aug 18, 2023

Added atomic dipole to test.py

The current code did not cover this case.

Signed-off-by: Hananeh Oliaei <94663315+hanao2@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (53a1078) 78.73% compared to head (e884478) 78.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2747      +/-   ##
==========================================
- Coverage   78.73%   78.72%   -0.02%     
==========================================
  Files         241      241              
  Lines       25582    25587       +5     
  Branches     1517     1517              
==========================================
+ Hits        20142    20143       +1     
- Misses       5048     5054       +6     
+ Partials      392      390       -2     
Files Changed Coverage Δ
deepmd/entrypoints/test.py 7.88% <0.00%> (-0.12%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz self-requested a review August 18, 2023 14:27
deepmd/entrypoints/test.py Outdated Show resolved Hide resolved
deepmd/entrypoints/test.py Outdated Show resolved Hide resolved
hanao2 and others added 2 commits August 22, 2023 16:05
Signed-off-by: Hananeh Oliaei <94663315+hanao2@users.noreply.github.com>
@wanghan-iapcm wanghan-iapcm changed the base branch from master to devel August 23, 2023 02:11
@wanghan-iapcm wanghan-iapcm merged commit 7146c3d into deepmodeling:devel Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants