Use module.__path__[0] instead of module.__file__
#2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deepmodeling#2751. If `__init__.py` does not exist, `module.__file__` is `None` (it is expected to give the path to `__init__.py`). In this case, `module.__path__[0]` will give the directory path. It's unclear why there is an empty directory without `__init__.py` in deepmodeling#2751. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## devel #2769 +/- ##
==========================================
- Coverage 78.72% 78.71% -0.01%
==========================================
Files 241 241
Lines 25610 25610
Branches 1517 1517
==========================================
- Hits 20162 20160 -2
Misses 5058 5058
- Partials 390 392 +2
☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2751.
If
__init__.pydoes not exist,module.__file__isNone(it is expected to give the path to__init__.py). In this case,module.__path__[0]will give the directory path.