Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update DPRc examples to make it compressible #2874

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Sep 27, 2023

  1. Update DPRc examples to make it compressible.
  2. It seems set_davg_zero is not required in the QM/QM descriptor. The atomic energies for QM atoms are not zero. In the QM/QM descriptor, the output of MM atoms is always zero, and set_davg_zero only takes effect in QM atoms.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e937345) 75.46% compared to head (0f54998) 75.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2874   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files         244      244           
  Lines       24518    24518           
  Branches     1580     1580           
=======================================
+ Hits        18502    18503    +1     
+ Misses       5085     5084    -1     
  Partials      931      931           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz requested a review from wanghan-iapcm September 27, 2023 21:26
@wanghan-iapcm wanghan-iapcm merged commit a184e3b into deepmodeling:devel Sep 30, 2023
njzjz added a commit to njzjz/dprc-tutorial that referenced this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants