cmake: support LAMMPS in built-in mode; remove kspace requirement #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deepmodeling#2875. Add documentation and supporting file to install LAMMPS in built-in mode with CMake. Compile required C++ files from the kspace package (pppm.cpp, ffft3d.cpp, ffft3d_wrap.cpp, remap.cpp, remap_wrap.cpp) in the CMake files for both built-in and plugin modes, so there is no need to set PKG_KSAPCE=ON. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2891 +/- ##
=======================================
Coverage 75.46% 75.46%
=======================================
Files 244 244
Lines 24518 24518
Branches 1580 1580
=======================================
Hits 18503 18503
Misses 5084 5084
Partials 931 931 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2875.
Add documentation and supporting file to install LAMMPS in built-in mode with CMake.
Compile required C++ files from the kspace package (pppm.cpp, ffft3d.cpp, ffft3d_wrap.cpp, remap.cpp, remap_wrap.cpp) in the CMake files for both built-in and plugin modes, so there is no need to set PKG_KSAPCE=ON.