Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: float32 bug in UTs #3314

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Fix: float32 bug in UTs #3314

merged 3 commits into from
Feb 22, 2024

Conversation

anyangml
Copy link
Collaborator

No description provided.

@anyangml anyangml marked this pull request as draft February 21, 2024 09:37
@anyangml anyangml added the Test CUDA Trigger test CUDA workflow label Feb 21, 2024
@github-actions github-actions bot removed the Test CUDA Trigger test CUDA workflow label Feb 21, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d629616) 75.31% compared to head (9744929) 22.48%.

Files Patch % Lines
deepmd/pt/model/network/mlp.py 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##            devel    #3314       +/-   ##
===========================================
- Coverage   75.31%   22.48%   -52.84%     
===========================================
  Files         401      401               
  Lines       33859    33846       -13     
  Branches     1604     1604               
===========================================
- Hits        25502     7610    -17892     
- Misses       7496    25677    +18181     
+ Partials      861      559      -302

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anyangml anyangml self-assigned this Feb 21, 2024
@anyangml anyangml requested a review from njzjz February 21, 2024 10:02
@anyangml anyangml mentioned this pull request Feb 21, 2024
Closed
@anyangml anyangml marked this pull request as ready for review February 21, 2024 10:03
@anyangml anyangml requested a review from njzjz February 21, 2024 11:18
@anyangml anyangml added the Test CUDA Trigger test CUDA workflow label Feb 21, 2024
@github-actions github-actions bot removed the Test CUDA Trigger test CUDA workflow label Feb 21, 2024
@njzjz njzjz linked an issue Feb 21, 2024 that may be closed by this pull request
[BUG] pt fitting has bug with float32 #3291
Closed
@anyangml anyangml added this pull request to the merge queue Feb 22, 2024
Merged via the queue into deepmodeling:devel with commit e565391 Feb 22, 2024
51 checks passed
@anyangml anyangml deleted the devel branch February 22, 2024 01:36
@anyangml anyangml restored the devel branch February 22, 2024 02:05
@njzjz njzjz mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz approved these changes

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

Assignees

@anyangml anyangml

Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] pt fitting has bug with float32
3 participants
@anyangml @njzjz @wanghan-iapcm