Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build): use uv for cibuildwheel #3695

Merged
merged 18 commits into from
Jun 11, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Apr 21, 2024

Should save 1 minute per build on average.

Summary by CodeRabbit

  • New Features

    • Introduced platform-specific constraints for h5py when using TensorFlow, ensuring better compatibility and performance.
  • Chores

    • Updated build configuration to include the uv tool for building wheels.
    • Modified .gitignore to exclude the .uv/ directory.

njzjz added 2 commits April 21, 2024 00:53
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (057dc11) to head (c14325e).
Report is 117 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3695   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         517      517           
  Lines       49724    49724           
  Branches     2986     2984    -2     
=======================================
  Hits        41105    41105           
  Misses       7709     7709           
  Partials      910      910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz marked this pull request as draft April 21, 2024 05:40
njzjz added 5 commits April 29, 2024 22:04
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link
Contributor

coderabbitai bot commented Jun 10, 2024

Warning

Rate limit exceeded

@njzjz has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 24 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between a4547f7 and c14325e.

Walkthrough

The recent changes primarily focus on enhancing the build process and dependency management for the project. Key updates include the addition of uv for building wheels, constraints for h5py based on platform specifics, and modifications to the .gitignore file. These improvements aim to streamline the build process and ensure compatibility across different systems.

Changes

File Change Summary
.github/workflows/build_wheel.yml Added a step to install uv using curl, updated cibuildwheel action to v2.19, and modified build commands.
.gitignore Included .uv/ directory.
backend/find_tensorflow.py Added constraints for h5py version based on platform system and machine in get_tf_requirement.
pyproject.toml Added test-requires for h5py, installed uv with pipx, and added conditional uv installation.

Sequence Diagram(s)

The changes do not introduce new features or modify control flow significantly, so no sequence diagrams are needed.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

.github/workflows/build_wheel.yml Show resolved Hide resolved
njzjz added 6 commits June 10, 2024 18:19
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review June 10, 2024 23:02
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (1)
backend/find_tensorflow.py (1)

Line range hint 105-105: Improve exception handling by using raise ... from None.

This will help in distinguishing the actual source of the error and improve the clarity of the traceback.

-        raise RuntimeError("Unsupported CUDA version")
+        raise RuntimeError("Unsupported CUDA version") from None

backend/find_tensorflow.py Show resolved Hide resolved
njzjz added 5 commits June 10, 2024 19:06
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This reverts commit 9343113.
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm June 11, 2024 00:07
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Jun 11, 2024
Merged via the queue into deepmodeling:devel with commit a7ab1af Jun 11, 2024
60 checks passed
@njzjz njzjz added this to the v2.2.11 milestone Jul 2, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Jul 2, 2024
Should save 1 minute per build on average.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced platform-specific constraints for `h5py` when using
TensorFlow, ensuring better compatibility and performance.

- **Chores**
- Updated build configuration to include the `uv` tool for building
wheels.
  - Modified `.gitignore` to exclude the `.uv/` directory.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit a7ab1af)
@njzjz njzjz mentioned this pull request Jul 2, 2024
njzjz added a commit that referenced this pull request Jul 3, 2024
Should save 1 minute per build on average.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced platform-specific constraints for `h5py` when using
TensorFlow, ensuring better compatibility and performance.

- **Chores**
- Updated build configuration to include the `uv` tool for building
wheels.
  - Modified `.gitignore` to exclude the `.uv/` directory.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit a7ab1af)
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
Should save 1 minute per build on average.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced platform-specific constraints for `h5py` when using
TensorFlow, ensuring better compatibility and performance.

- **Chores**
- Updated build configuration to include the `uv` tool for building
wheels.
  - Modified `.gitignore` to exclude the `.uv/` directory.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants