bug: fix no raise RuntimeError

[iProzd]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling in the neighbor list building process to provide clearer error messages when atom distances are too close.

[coderabbitai]

Walkthrough

Walkthrough

The recent update in the codebase involves a correction in the error handling approach within the build_neighbor_list function. Previously, an error was indicated but not properly raised, potentially leading to unhandled exceptions. The modification ensures that a RuntimeError is explicitly raised when atom distances are too close, enhancing the robustness and clarity of error management in the function.

Changes

File	Change Summary
deepmd/pt/utils/preprocess.py	Updated error handling in build_neighbor_list to properly raise RuntimeError when atom distances are too close.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d48f84a and e924965.

Files selected for processing (1)

• deepmd/pt/utils/preprocess.py (1 hunks)

Files skipped from review due to trivial changes (1)

• deepmd/pt/utils/preprocess.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.85%. Comparing base (d48f84a) to head (e924965).

Files	Patch %	Lines
deepmd/pt/utils/preprocess.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##            devel    #3748       +/-   ##
===========================================
- Coverage   82.23%   66.85%   -15.38%     
===========================================
  Files         513      412      -101     
  Lines       47745    34125    -13620     
  Branches     2979      910     -2069     
===========================================
- Hits        39261    22814    -16447     
- Misses       7573    10896     +3323     
+ Partials      911      415      -496     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.