Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #3938

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.10 → v0.5.0](astral-sh/ruff-pre-commit@v0.4.10...v0.5.0)
- [github.com/asottile/blacken-docs: 1.16.0 → 1.18.0](adamchainz/blacken-docs@1.16.0...1.18.0)
- [github.com/pre-commit/mirrors-clang-format: v18.1.7 → v18.1.8](pre-commit/mirrors-clang-format@v18.1.7...v18.1.8)
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (20aeaf8) to head (807fb1d).
Report is 113 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3938      +/-   ##
==========================================
+ Coverage   82.88%   83.09%   +0.21%     
==========================================
  Files         520      520              
  Lines       50679    51724    +1045     
  Branches     3015     3026      +11     
==========================================
+ Hits        42003    42978     +975     
- Misses       7740     7809      +69     
- Partials      936      937       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz
Copy link
Member

njzjz commented Jul 2, 2024

deepmd/utils/data.py:445:17: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
443 |         for kk in data:
444 |             if (
445 |                 type(data[kk]) == np.ndarray
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ E721
446 |                 and len(data[kk].shape) == 2
447 |                 and data[kk].shape[0] == nframes
    |

source/tests/common/test_argument_parser.py:177:20: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
175 |                 else:
176 |                     t = data["type"]
177 |                 if t == str:
    |                    ^^^^^^^^ E721
178 |                     required.append("STRING")
179 |                 elif t in (int, float):
    |

Found 2 errors.

@github-actions github-actions bot added the Python label Jul 2, 2024
@njzjz njzjz enabled auto-merge July 2, 2024 19:42
source/tests/common/test_argument_parser.py Outdated Show resolved Hide resolved
source/tests/common/test_argument_parser.py Outdated Show resolved Hide resolved
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz added this pull request to the merge queue Jul 2, 2024
Merged via the queue into devel with commit f2223fb Jul 2, 2024
108 checks passed
@njzjz njzjz deleted the pre-commit-ci-update-config branch July 2, 2024 22:34
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
<!--pre-commit.ci start-->
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.10 →
v0.5.0](astral-sh/ruff-pre-commit@v0.4.10...v0.5.0)
- [github.com/asottile/blacken-docs: 1.16.0 →
1.18.0](adamchainz/blacken-docs@1.16.0...1.18.0)
- [github.com/pre-commit/mirrors-clang-format: v18.1.7 →
v18.1.8](pre-commit/mirrors-clang-format@v18.1.7...v18.1.8)
<!--pre-commit.ci end-->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants