-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cc): compile select_map<int>
when TensorFlow backend is off
#3987
Conversation
…bled `select_map<int>` is currently within the `BUILD_TENSORFLOW` condition block, which is wrong. The C API uses it. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
WalkthroughWalkthroughThis change introduces conditional compilation using preprocessor directives to the template functions Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3987 +/- ##
==========================================
- Coverage 82.83% 82.82% -0.01%
==========================================
Files 522 522
Lines 50876 50876
Branches 3019 3015 -4
==========================================
- Hits 42142 42139 -3
Misses 7799 7799
- Partials 935 938 +3 ☔ View full report in Codecov by Sentry. |
…epmodeling#3987) `select_map<int>` is currently within the `BUILD_TENSORFLOW` condition block, which is wrong. The C API uses it. This issue is found on a machine when only building against libtorch. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved compatibility with TensorFlow by adding conditional compilation directives. - **Enhancements** - Enhanced handling of session data with new template functions for vectors and scalars. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
select_map<int>
is currently within theBUILD_TENSORFLOW
condition block, which is wrong. The C API uses it. This issue is found on a machine when only building against libtorch.Summary by CodeRabbit
New Features
Enhancements