-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow model arguments to be registered outside #3995
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
WalkthroughWalkthroughSignificant updates were made to Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant ArgsPlugin
participant ModelRegistry
Developer->>ArgsPlugin: Define new model argument decorators
ArgsPlugin->>ModelRegistry: Register model argument plugins (e.g., "standard", "frozen")
Developer->>ArgsPlugin: Introduce hybrid model arguments
ArgsPlugin->>ModelRegistry: Register hybrid model argument plugins (e.g., "pairwise_dprc", "linear_ener")
ModelRegistry->>Developer: Model arguments registered and ready for use
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3995 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 522 522
Lines 50889 50901 +12
Branches 3015 3015
=======================================
+ Hits 42154 42165 +11
- Misses 7798 7799 +1
Partials 937 937 ☔ View full report in Codecov by Sentry. |
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced new plugins for handling model arguments, including `standard`, `frozen`, `pairtab`, `pairwise_dprc`, and `linear_ener` models. - Added support for hybrid models that require another model as input. - **Improvements** - Enhanced argument-checking mechanisms to accommodate complex return types and nested structures. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Summary by CodeRabbit
New Features
standard
,frozen
,pairtab
,pairwise_dprc
, andlinear_ener
models.Improvements