-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make dp neighbor-stat --type-map
optional
#4049
feat: make dp neighbor-stat --type-map
optional
#4049
Conversation
In most cases, we can directly read type map from data. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
WalkthroughWalkthroughThe recent changes enhance the flexibility and usability of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #4049 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 522 522
Lines 51040 51041 +1
Branches 3028 3028
=======================================
+ Hits 42336 42337 +1
+ Misses 7759 7757 -2
- Partials 945 947 +2 ☔ View full report in Codecov by Sentry. |
In most cases, we can directly read type map from data. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - The `neighbor_stat` function now accepts an optional `type_map`, enhancing flexibility in function calls. - The `--type-map` argument in the main parser has been changed to optional, defaulting to a derived type map if not provided. - **Improvements** - Added logging to indicate when the `type_map` is not supplied, enhancing user awareness and debugging capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
In most cases, we can directly read type map from data.
Summary by CodeRabbit
New Features
neighbor_stat
function now accepts an optionaltype_map
, enhancing flexibility in function calls.--type-map
argument in the main parser has been changed to optional, defaulting to a derived type map if not provided.Improvements
type_map
is not supplied, enhancing user awareness and debugging capabilities.