-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve error message for inconsistent type maps #4074
docs: improve error message for inconsistent type maps #4074
Conversation
Fix deepmodeling#4034. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
WalkthroughWalkthroughThe changes enhance the error handling in the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
deepmd/utils/data_system.py (1)
616-620
: Enhanced error message is clear and informative.The updated error message provides better guidance to users, aligning with the PR objectives. Consider rephrasing for clarity:
- "If you didn't set model/type_map, please set it, " - "since the type map of the model cannot be decided by data." + "Please set the model/type_map, as it cannot be inferred from the data."
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #4074 +/- ##
==========================================
- Coverage 82.95% 82.94% -0.01%
==========================================
Files 522 522
Lines 51044 51044
Branches 3028 3028
==========================================
- Hits 42343 42338 -5
- Misses 7756 7758 +2
- Partials 945 948 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…4074) Fix deepmodeling#4034. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced error messaging for type map inconsistencies to provide clearer guidance for users on configuration issues. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Fix #4034.
Summary by CodeRabbit