Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Wrap log_path with Path #4117

Merged
merged 3 commits into from
Sep 12, 2024
Merged

[Fix] Wrap log_path with Path #4117

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fe5f64
Wrap log_path with Path
HydrogenSulfate Sep 10, 2024
31edbb1
fix for logpath is None
HydrogenSulfate Sep 11, 2024
5466939
Update main.py
HydrogenSulfate Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion deepmd/pt/entrypoints/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,11 @@
else:
FLAGS = args

set_log_handles(FLAGS.log_level, FLAGS.log_path, mpi_log=None)
set_log_handles(

Check warning on line 558 in deepmd/pt/entrypoints/main.py

View check run for this annotation

Codecov / codecov/patch

deepmd/pt/entrypoints/main.py#L558 

Added line #L558 was not covered by tests
FLAGS.log_level,
Path(FLAGS.log_path) if FLAGS.log_path else None,
mpi_log=None,
)
log.debug("Log handles were successfully set")
log.info("DeePMD version: %s", __version__)

Expand Down