Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pt): remove deprecating torch.norm #4233

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

wanghan-iapcm
Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm commented Oct 20, 2024

Summary by CodeRabbit

  • Chores
    • Updated the normalization method for improved consistency and potential optimization.
    • Minor code formatting adjustments for enhanced readability.
    • Ensured compatibility with existing function calls by preserving parameters and return types.

@wanghan-iapcm wanghan-iapcm requested a review from njzjz October 20, 2024 05:03
@wanghan-iapcm wanghan-iapcm linked an issue Oct 20, 2024 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Oct 20, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request primarily involve modifications to the extend_coord_with_ghosts function within the deepmd/pt/utils/nlist.py file. The updates include a shift from using torch.norm to torch.linalg.norm for calculating the norm of the xyz tensor, along with minor code formatting improvements. The overall functionality and structure of the code remain unchanged, ensuring compatibility with existing function calls.

Changes

File Path Change Summary
deepmd/pt/utils/nlist.py - Updated norm calculation from torch.norm(xyz, dim=1) to torch.linalg.norm(xyz, dim=-1).
- Minor formatting adjustments for code readability.
- No changes to function parameters or return types.

Possibly related issues

  • [BUG] torch.norm is deprecated #4229: This change addresses the issue of using the deprecated torch.norm function by replacing it with torch.linalg.norm, which is consistent with the bug report.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cc4b23d and cfa42be.

📒 Files selected for processing (1)
  • deepmd/pt/utils/nlist.py (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
deepmd/pt/utils/nlist.py (1)

460-460: Excellent update to use torch.linalg.norm!

This change from torch.norm to torch.linalg.norm is a positive improvement. It aligns with PyTorch's best practices by using the more stable and consistent torch.linalg module for linear algebra operations. The functionality remains the same, calculating the Euclidean norm along the last dimension of the xyz tensor.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.55%. Comparing base (cc4b23d) to head (cfa42be).
Report is 1 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #4233      +/-   ##
==========================================
- Coverage   84.55%   84.55%   -0.01%     
==========================================
  Files         537      537              
  Lines       51237    51238       +1     
  Branches     3047     3047              
==========================================
- Hits        43324    43323       -1     
- Misses       6965     6969       +4     
+ Partials      948      946       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz enabled auto-merge October 20, 2024 05:49
@njzjz njzjz added this pull request to the merge queue Oct 20, 2024
Merged via the queue into deepmodeling:devel with commit c2944eb Oct 20, 2024
60 checks passed
@wanghan-iapcm wanghan-iapcm deleted the fix-torch-norm branch October 21, 2024 14:39
@coderabbitai coderabbitai bot mentioned this pull request Nov 28, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] torch.norm is deprecated
2 participants