fix(lmp): update print_summary #4271
Conversation
1. Remove out-of-date float prec; 2. Include PyTorch libraries and include directories. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- source/lmp/deepmd_version.h.in (1 hunks)
- source/lmp/pair_deepmd.cpp (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- source/lmp/pair_deepmd.cpp
🔇 Additional comments (1)
source/lmp/deepmd_version.h.in (1)
6-7: Verify impact on dependent code.
The change from TensorFlow-specific to backend-generic variables is significant. Let's verify all usages to ensure consistent updates.
✅ Verification successful
Let me check the actual usage of these macros in the identified files to ensure the changes are consistent.
The change from TensorFlow to backend-generic variables is safe and properly reflected in dependent code.
The verification shows that the macro renaming is consistent with its usage:
- In
pair_deepmd.cpp, the macros are only used for logging build information - In
version.h.in, the variables are already using generic names (global_tf_*) - The remaining TensorFlow-specific includes and defines in the codebase are in the TensorFlow-specific implementation files under
source/op/tf/which are not affected by this change
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for direct usage of these macros
echo "Searching for direct macro usage..."
rg -l "TensorFlow_INCLUDE_DIRS|TensorFlow_LIBRARY" --type cpp
# Search for string versions of these macros
echo "Searching for string macro usage..."
rg -l "STR_TensorFlow_INCLUDE_DIRS|STR_TensorFlow_LIBRARY" --type cpp
# Look for any remaining TensorFlow-specific path references
echo "Checking for any remaining TensorFlow-specific paths..."
rg -l "tensorflow" --type cmake
Length of output: 742
Script:
#!/bin/bash
# Check the usage in pair_deepmd.cpp
echo "=== Content of pair_deepmd.cpp where macros are used ==="
rg -C 5 "TensorFlow_(INCLUDE_DIRS|LIBRARY)" source/lmp/pair_deepmd.cpp
echo -e "\n=== Content of version.h.in where macros are used ==="
cat source/api_cc/include/version.h.in
# Check if there are any other tensorflow-related defines or includes
echo -e "\n=== Any other tensorflow-related defines or includes ==="
rg "#\s*(include|define).*tensorflow" --type cpp
Length of output: 3626
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4271 +/- ##
==========================================
+ Coverage 84.34% 84.37% +0.03%
==========================================
Files 549 551 +2
Lines 51463 51583 +120
Branches 3053 3052 -1
==========================================
+ Hits 43406 43523 +117
- Misses 7097 7100 +3
Partials 960 960 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
Summary by CodeRabbit