Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devel-CMake] Fix Python interpreter not defined. #776

Closed
wants to merge 1 commit into from

Conversation

shishaochen
Copy link
Collaborator

@shishaochen shishaochen commented Jun 20, 2021

With CMake built-in API FindPython, user can avoid explicity decaring variable PYTHON_EXECUTABLE.

@shishaochen shishaochen changed the title [devel] Fix Python interpreter not defined. [devel-CMake] Fix Python interpreter not defined. Jun 20, 2021
@amcadmus amcadmus requested a review from njzjz June 20, 2021 14:28
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2021

Codecov Report

Merging #776 (381b605) into devel (f326a86) will decrease coverage by 7.63%.
The diff coverage is n/a.

❗ Current head 381b605 differs from pull request most recent head 3877480. Consider uploading reports for the commit 3877480 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #776      +/-   ##
==========================================
- Coverage   74.30%   66.66%   -7.64%     
==========================================
  Files          82        6      -76     
  Lines        6534       15    -6519     
==========================================
- Hits         4855       10    -4845     
+ Misses       1679        5    -1674     
Impacted Files Coverage Δ
deepmd/infer/deep_wfc.py
deepmd/descriptor/loc_frame.py
deepmd/__init__.py
deepmd/entrypoints/__init__.py
deepmd/entrypoints/freeze.py
deepmd/utils/argcheck.py
deepmd/loggers/__init__.py
deepmd/train/run_options.py
deepmd/utils/data.py
source/op/_soft_min_virial_grad.py
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f326a86...3877480. Read the comment docs.

@njzjz njzjz self-assigned this Jun 20, 2021
@shishaochen shishaochen deleted the devel-cmake branch June 20, 2021 23:45
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants