Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow c++ tests to run without internet #785

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

y1xiaoc
Copy link
Contributor

@y1xiaoc y1xiaoc commented Jun 22, 2021

Current test_cc.sh script for c++ unit tests would download and install gtest and libtensorflow anyway even if they are already installed. I added a new script and refined the cmake files to allow the test being run locally without download anything.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #785 (598af67) into devel (44d49f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #785   +/-   ##
=======================================
  Coverage   74.30%   74.30%           
=======================================
  Files          82       82           
  Lines        6534     6534           
=======================================
  Hits         4855     4855           
  Misses       1679     1679           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d49f3...598af67. Read the comment docs.

@amcadmus amcadmus requested a review from njzjz June 22, 2021 05:22
@amcadmus amcadmus merged commit b15944d into deepmodeling:devel Jun 22, 2021
@y1xiaoc y1xiaoc deleted the test_local branch June 23, 2021 06:39
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
* fix bug when trying to find gtest in cmake

* link librt explicitly

* add script to test cc without installing tf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants