-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug of empty input in gelu.cu #800
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #800 +/- ##
=======================================
Coverage 73.96% 73.96%
=======================================
Files 84 84
Lines 6588 6588
=======================================
Hits 4873 4873
Misses 1715 1715 Continue to review full report at Codecov.
|
Devel update
Is our gelu much faster than TensorFlow's (tensorflow/tensorflow#41178)? It seems that they implement gelu only using some python codes. See https://github.com/tensorflow/tensorflow/blob/v2.5.0/tensorflow/python/ops/nn_ops.py#L3505-L3548 |
Yes, that's why we implement gelu by ourselves |
* add gpu op unittest in source/tests * fix bug in deepmodeling#713 * Fix bug of empty input in gelu.cu
#675 and #742 maybe the same bugs when:
this causes the empty input in gelu.cu and thus breaks.