raise warning before training if sel is not enough
#914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently I can't see any warning during the training if sel is not enough, so it's a good idea to check it before training, and tell the user what to do. Also fix deepmodeling#874.
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #914 +/- ##
==========================================
+ Coverage 74.68% 74.94% +0.25%
==========================================
Files 85 85
Lines 6748 6753 +5
==========================================
+ Hits 5040 5061 +21
+ Misses 1708 1692 -16 ☔ View full report in Codecov by Sentry. |
denghuilu
approved these changes
Aug 1, 2021
amcadmus
approved these changes
Aug 2, 2021
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 2, 2021
Currently I can't see any warning during the training if sel is not enough, so it's a good idea to check it before training, and tell the user what to do. Also fix deepmodeling#874.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I can't see any warning during the training if
selis not enough, so it's a good idea to check it before training, and tell the user what to do.Also fix #874.