Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message needed to be revised #1553

Closed
thangckt opened this issue May 24, 2024 · 1 comment · Fixed by #1554 or thangckt/dpgen#15
Closed

Error message needed to be revised #1553

thangckt opened this issue May 24, 2024 · 1 comment · Fixed by #1554 or thangckt/dpgen#15
Labels
bug Something isn't working

Comments

@thangckt
Copy link
Contributor

Summary

Dear Developers,

I think this line in file dpgen/data/gen.py should be revised for better description

680:         raise RuntimeError( "not file %s, vasp relaxation should be run before scale poscar" )

There is no value for string format.

DP-GEN Version

devel

Platform, Python Version, etc

No response

Details

.
@njzjz njzjz added the bug Something isn't working label May 24, 2024
@njzjz
Copy link
Member

njzjz commented May 25, 2024

git blame: 8a78d09

FYI @wanghan-iapcm

@wanghan-iapcm wanghan-iapcm mentioned this issue May 27, 2024
Merged
wanghan-iapcm added a commit that referenced this issue May 27, 2024
@wanghan-iapcm
Fix exception message (#1554)
7491eb9 
fixes #1553

Co-authored-by: Han Wang <wang_han@iapcm.ac.cn>
@thangckt thangckt mentioned this issue May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix exception message wanghan-iapcm/dpgen
Fix exception message (#1554) deepmodeling/dpgen
2 participants
@njzjz @thangckt