Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] _different trust level for different sys_idx_ #746

Closed
phyoung123 opened this issue Jun 1, 2022 · 1 comment
Closed

[BUG] _different trust level for different sys_idx_ #746

phyoung123 opened this issue Jun 1, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@phyoung123
Copy link

phyoung123 commented Jun 1, 2022

Summary

When I set a list for model_devi_f_trust_lo and model_devi_f_trust_hi following #609, No matter how I change this parameter, excepting just one float, the problem is never solved.
A list I set
image

Error message
image

DPGEN Version and Platform

DPGEN version : 0.10.5

Further Information, Files, and Links

I also attempt to modify the resource code in dpgen/generator/run.py, line 1757-1760, 'ss' is changed to 'int(ss)'
image

Now it works. But another question is:
The length of the list does not coordinate with the number of sys_idx. As long as the length of the list is larger than the number of sys_configs, it works. But does the aim of the list is to set different trust level for different sys_idx or sys_configs? you know the number of sys_idx is not equal to sys_configs. This change is likely to be set for different sys_configs. If I want to set different trust level for different sys_idx or each iteration step, what should I do?

@phyoung123 phyoung123 added the bug Something isn't working label Jun 1, 2022
@Cloudac7
Copy link
Contributor

Cloudac7 commented Jul 7, 2022

Sorry for replying after as long as a month passed, for no e-mail notification until I just checked the inbox (perhaps due to some issue, I guess. Sorry). I have read the original discussion as well as the issue, it seems that I forgot to convert string back to integer. Would be fixed soon.

If I want to set different trust level for different sys_idx or each iteration step, what should I do?

It is an interesting enhancement for I just met the issue and now working to make it work. However, it is now global parameters that control the model deviation trust level. Would just covering them with local ones be a good idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants