Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choose numb_steps/stop_batch automatically #1086

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Dec 23, 2022

Fix #1084. Both keys are valid, so we detect which one is used in default_training_param.

Both keys are valid in DeePMD-kit v2
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.55%. Comparing base (1bb85a6) to head (475eb37).
Report is 195 commits behind head on devel.

Files Patch % Lines
dpgen/generator/run.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1086   +/-   ##
=======================================
  Coverage   39.54%   39.55%           
=======================================
  Files          99       99           
  Lines       17979    17981    +2     
=======================================
+ Hits         7110     7112    +2     
  Misses      10869    10869           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit a9d324b into deepmodeling:devel Dec 23, 2022
@njzjz njzjz linked an issue Dec 24, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get "undefined key "stop_batch" is not allowed in strict mode" error
3 participants