Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fp: add document and example for Quantum Espresso #1405

Merged
merged 7 commits into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 40 additions & 3 deletions dpgen/generator/arginfo.py
Original file line number Diff line number Diff line change
Expand Up @@ -790,13 +790,14 @@ def fp_style_cp2k_args() -> list[Argument]:
]


# amber/diff
def fp_style_amber_diff_args() -> list[Argument]:
"""Arguments for FP style amber/diff.

Returns
-------
list[dargs.Argument]
list of Gaussian fp style arguments
list of amber/diff fp style arguments
"""
doc_fp_params_gaussian = "Parameters for FP calculation."
doc_high_level = (
Expand Down Expand Up @@ -827,13 +828,49 @@ def fp_style_amber_diff_args() -> list[Argument]:
]


# pwscf
def fp_style_pwscf_args() -> list[Argument]:
"""Arguments for FP style pwscf (Quantum Espresso).

Returns
-------
list[dargs.Argument]
list of pwscf fp style arguments
"""
doc_fp_pp_path = "Directory of psuedo-potential file to be used for 02.fp exists."
doc_fp_pp_files = "Psuedo-potential file to be used for 02.fp. Note that the order of elements should correspond to the order in type_map."
doc_user_fp_params = "Parameters for pwscf calculation. Find details at https://www.quantum-espresso.org/Doc/INPUT_PW.html. When user_fp_params is set, the settings in fp_params will be ignored. kspacing must be set in user_fp_params. kspacing is the spacing between kpoints, and helps to determin KPOINTS in pwscf."
doc_fp_params = (
"Parameters for pwscf calculation. It has lower priority than user_fp_params."
)
doc_ecut = "ecutwfc in pwscf."
doc_ediff = "conv_thr and ts_vdw_econv_thr in pwscf."
doc_kspacing = "The spacing between kpoints. Helps to determin KPOINTS in pwscf."
doc_smearing = "smearing in pwscf."
doc_sigma = "degauss in pwscf."

args = [
Argument("ecut", float, optional=False, doc=doc_ecut),
Argument("ediff", float, optional=False, doc=doc_ediff),
Argument("smearing", str, optional=False, doc=doc_smearing),
Argument("sigma", float, optional=False, doc=doc_sigma),
]
return [
Argument("fp_pp_path", str, optional=False, doc=doc_fp_pp_path),
Argument("fp_pp_files", list[str], optional=False, doc=doc_fp_pp_files),
Argument("fp_params", dict, args, [], optional=False, doc=doc_fp_params),
Argument("user_fp_params", dict, optional=True, doc=doc_user_fp_params),
Argument("kspacing", float, optional=False, doc=doc_kspacing),
]


def fp_style_custom_args() -> list[Argument]:
"""Arguments for FP style custom.

Returns
-------
list[dargs.Argument]
list of Gaussian fp style arguments
list of custom fp style arguments
"""
doc_fp_params_custom = "Parameters for FP calculation."
doc_input_fmt = "Input dpdata format of the custom FP code. Such format should only need the first argument as the file name."
Expand Down Expand Up @@ -883,7 +920,7 @@ def fp_style_variant_type_args() -> Variant:
"amber/diff", dict, fp_style_amber_diff_args(), doc=doc_amber_diff
),
Argument("pwmat", dict, [], doc="TODO: add doc"),
Argument("pwscf", dict, [], doc="TODO: add doc"),
Argument("pwscf", dict, [], doc=fp_style_pwscf_args()),
Yi-FanLi marked this conversation as resolved.
Show resolved Hide resolved
Argument("custom", dict, fp_style_custom_args(), doc=doc_custom),
],
optional=False,
Expand Down
1 change: 1 addition & 0 deletions examples/run/dp2.x-lammps-pwscf/Al/Al_ONCV_PBE_sr.upf
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
You may download the needed pseudopotential files online. An example is https://github.com/pipidog/ONCVPSP.
Loading
Loading