model devi: download LAMMPS log files for pimd #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
njzjz
added a commit
to njzjz/dpdispatcher
that referenced
this pull request
Nov 20, 2023
deepmodeling#409 avoids retry in loop when the file is not found in the ssh context. But it is not apply to other contexts, and the tests hang in deepmodeling/dpgen#1406 due to retry.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #1406 +/- ##
==========================================
+ Coverage 48.98% 49.03% +0.04%
==========================================
Files 83 83
Lines 14796 14809 +13
==========================================
+ Hits 7248 7261 +13
Misses 7548 7548 ☔ View full report in Codecov by Sentry. |
njzjz
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put LAMMPS's log files in backward_files for pimd