Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove set_prefix #1537

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 6, 2024

See:

Summary by CodeRabbit

  • Refactor
    • Removed the "set_prefix": "set" attribute across various JSON and YAML configuration files, streamlining data handling and batch processing setups.

Copy link
Contributor

coderabbitai bot commented May 6, 2024

Walkthrough

The recent updates involve the systematic removal of the "set_prefix": "set" attribute from the training_data section in various JSON and YAML configuration files. This change indicates a shift in how training data prefixes are managed, potentially streamlining configuration processes or adapting to new standards in data handling.

Changes

Files Affected Change Summary
Various param.json, param.yaml files in examples/run/..., tests/generator/... Removed "set_prefix": "set" from training_data.
param_CH4_deepmd-kit-2.0.1.json, param_C4H16N4_deepmd-kit-2.0.1.json in examples/run/dp2.x-lammps-gaussian/ Removed _set_prefix attribute from the training section.
doc/simplify/simplify.md, examples/simplify/qm7.json Removed "set_prefix": "set" declaration under training_data.
tests/tools/run_report_test_output/param.json Removal of "set_prefix": "set" under "training_data".

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (3)
doc/simplify/simplify.md (3)

Line range hint 1-119: Ensure that headings are surrounded by blank lines for better readability and adherence to Markdown formatting standards.

+ 
## Simplify
+ 
When you have a dataset containing lots of repeated data, this step will help you simplify your dataset.

Line range hint 119-119: Add a comma after "simplify" to improve the readability of the sentence.

- ...pick_data>` is the directory to data to simplify where the program recursively detects systems...
+ ...pick_data>` is the directory to data to simplify, where the program recursively detects systems...

Line range hint 1-119: Ensure that fenced code blocks are surrounded by blank lines to comply with Markdown best practices.

+ 
```bash
dpgen simplify param.json machine.json

Here is an example of param.json for QM7 dataset:
+


</blockquote></details></blockquote></details>



<!-- This is an auto-generated comment by CodeRabbit for review status -->

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.49%. Comparing base (f240e8b) to head (22c0aa6).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1537   +/-   ##
=======================================
  Coverage   49.49%   49.49%           
=======================================
  Files          83       83           
  Lines       14816    14816           
=======================================
  Hits         7333     7333           
  Misses       7483     7483           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit d5dd205 into deepmodeling:devel May 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants