bug_fix | init_bulk | stages 3 | lost the last pert-dir in stages 2 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pert_numb = jdata['pert_numb'] stages 2 pert makes 000000+pert_numb structures (dirs), pert_numb + 1 in total stages 3 was copying those in range(pert_numb), the first pert_numb structures(dir), lost the last one.
Codecov Report
@@ Coverage Diff @@
## devel #530 +/- ##
=======================================
Coverage 33.04% 33.04%
=======================================
Files 86 86
Lines 14730 14730
=======================================
Hits 4867 4867
Misses 9863 9863
Continue to review full report at Codecov.
|
Cloudac7
pushed a commit
to Cloudac7/dpgen
that referenced
this pull request
Dec 1, 2021
…eepmodeling#530) pert_numb = jdata['pert_numb'] stages 2 pert makes 000000+pert_numb structures (dirs), pert_numb + 1 in total stages 3 was copying those in range(pert_numb), the first pert_numb structures(dir), lost the last one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pert_numb = jdata['pert_numb']
stages 2 pert makes 000000+pert_numb structures (dirs), pert_numb + 1 in total
stages 3 was copying those in range(pert_numb), the first pert_numb structures(dir), lost the last one.