Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mv to cp when downloading softlinks. #562

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

AnguseZhang
Copy link
Collaborator

If the file to be downloaded is a softlink, cp should be performed instead of mv. Otherwise, lfile is still a file linked to some original file, and when this file's removed, lfile will be invalid.

@AnguseZhang AnguseZhang requested review from felix5572 and njzjz October 6, 2021 06:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #562 (c8407e8) into devel (11ce228) will increase coverage by 0.12%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #562      +/-   ##
==========================================
+ Coverage   32.91%   33.03%   +0.12%     
==========================================
  Files          86       86              
  Lines       14629    14739     +110     
==========================================
+ Hits         4815     4869      +54     
- Misses       9814     9870      +56     
Impacted Files Coverage Δ
dpgen/dispatcher/LocalContext.py 89.47% <66.66%> (-0.53%) ⬇️
dpgen/generator/run.py 65.80% <0.00%> (-0.69%) ⬇️
dpgen/data/gen.py 51.04% <0.00%> (-0.17%) ⬇️
dpgen/dispatcher/ALI.py 0.00% <0.00%> (ø)
dpgen/remote/decide_machine.py 100.00% <0.00%> (ø)
dpgen/generator/lib/gaussian.py 31.57% <0.00%> (+0.19%) ⬆️
dpgen/generator/lib/lammps.py 72.59% <0.00%> (+4.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ce228...c8407e8. Read the comment docs.

@AnguseZhang
Copy link
Collaborator Author

@felix5572 This should also be applied to dpdispatcher.

@AnguseZhang AnguseZhang merged commit a07b6c6 into deepmodeling:devel Oct 6, 2021
Cloudac7 pushed a commit to Cloudac7/dpgen that referenced this pull request Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants