Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change compress level to 6 from default 9 to accelerate compress #593

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

taipinghu
Copy link
Contributor

@taipinghu taipinghu commented Nov 20, 2021

In some case, FP calculations could read the wave function file or charge files (e.g., CHGCAR and WAVECAR in VASP ). If the size of those files is too big, the compress process could be very slow due to the default setting (compresslevel=9) in tarfile module of python. Change the compresslevel to 6 will accelate compress rate.

@wanghan-iapcm
Copy link
Contributor

@felix5572 @njzjz Is this change submitted to the dpdispatcher?

@njzjz
Copy link
Member

njzjz commented Nov 21, 2021

@felix5572 @njzjz Is this change submitted to the dpdispatcher?

Not yet but it should.

@wanghan-iapcm
Copy link
Contributor

@njzjz Do you have any idea why the UTs failed?

@njzjz
Copy link
Member

njzjz commented Nov 22, 2021

@njzjz Do you have any idea why the UTs failed?

Maybe a dependency is lacked in dpdata. I'll add it.

@njzjz
Copy link
Member

njzjz commented Nov 22, 2021

@njzjz Do you have any idea why the UTs failed?

Maybe a dependency is lacked in dpdata. I'll add it.

deepmodeling/dpdata#227

@wanghan-iapcm
Copy link
Contributor

@njzjz Do you have any idea why the UTs failed?

Maybe a dependency is lacked in dpdata. I'll add it.

deepmodeling/dpdata#227

Why it was not triggered by the UTs of dpdata?

@njzjz
Copy link
Member

njzjz commented Nov 23, 2021

It is a dependency of something else? It was indeed installed in the UT workflow of dpdata.

@wanghan-iapcm
Copy link
Contributor

I see. strange enough...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants