-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bcc interstitial calculation and change some default parameters in lmp #696
Conversation
kevinwenminion
commented
Apr 10, 2022
- Add bcc interstitial calculations for transition metals which have six types of interstitial positions.
- In lmp relaxation, change the convergence to be controlled by the force criteria. This is more reasonable, especially for large systems.
- Change the "pair_coeff" in lmp to be compatible with the latest lmp version.
Codecov Report
@@ Coverage Diff @@
## devel #696 +/- ##
==========================================
- Coverage 33.94% 33.73% -0.21%
==========================================
Files 86 86
Lines 15424 15525 +101
==========================================
+ Hits 5235 5237 +2
- Misses 10189 10288 +99
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a UT for added the BCC interstitial?
Yes, I will add the unittest. |
BCC interstitial unittest has been added. |