Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Performing the Run process.md #714

Merged
merged 25 commits into from
May 31, 2022
Merged

Create Performing the Run process.md #714

merged 25 commits into from
May 31, 2022

Conversation

LiangWenshuo1118
Copy link
Contributor

Description of the steps and output files in the DP-GEN run process.

@LiangWenshuo1118
Create Performing the Run process.md
09f082b 
Description of the output files in DP-GEN run process.
@LiangWenshuo1118
Create Specify the Run process.md
65ccd26 
Description of an example of param.json.
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #714 (b6acd00) into devel (33baad0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel     #714   +/-   ##
=======================================
  Coverage   33.91%   33.91%           
=======================================
  Files          93       93           
  Lines       16562    16562           
=======================================
  Hits         5617     5617           
  Misses      10945    10945

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33baad0...b6acd00. Read the comment docs.

@AnguseZhang
Copy link
Collaborator

I've provided my suggestions with @LiangWenshuo1118.

njzjz
njzjz requested changes Apr 27, 2022
View reviewed changes
doc/run/Overview-of-the-run-process.md Outdated Show resolved Hide resolved
doc/run/example-of-param.md Outdated Show resolved Hide resolved
njzjz
njzjz reviewed Apr 30, 2022
View reviewed changes
Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these doc to doc/index.rst?

doc/run/example-of-machine.md Outdated Show resolved Hide resolved
doc/run/example-of-machine.md Outdated Show resolved Hide resolved
doc/run/example-of-param.md Outdated Show resolved Hide resolved
doc/run/overview-of-the-run-process.md Outdated Show resolved Hide resolved
@njzjz
Copy link
Member

njzjz commented May 9, 2022

  1. For maintenance, it's better to submit the original script instead of the generated doc.
  2. It's better to separate it into a new PR instead of doing all things in a single PR.

@wanghan-iapcm wanghan-iapcm merged commit 80f2cf7 into deepmodeling:devel May 31, 2022
@njzjz njzjz added the documentation Improvements or additions to documentation label Jun 11, 2022
@njzjz njzjz mentioned this pull request Jul 7, 2022
Closed
@njzjz njzjz linked an issue Jul 7, 2022 that may be closed by this pull request
A detailed document about para.json and machine.json #422
Closed
@njzjz njzjz mentioned this pull request Jul 7, 2022
Closed
@njzjz njzjz linked an issue Jul 7, 2022 that may be closed by this pull request
restart dpgen run process #460
Closed
@njzjz njzjz mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnguseZhang AnguseZhang AnguseZhang approved these changes

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Add docs for DP-GEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

restart dpgen run process A detailed document about para.json and machine.json
5 participants
@LiangWenshuo1118 @codecov-commenter @AnguseZhang @njzjz @wanghan-iapcm