supports non-list mdata #748
Conversation
The mdata of a task is a list of a single dict. This "list" looks useless and not clear enough. So this commit supports using the dict without a list. Note that old parameters are still supported, so no breaking changes are made. The "list" is just removed from all examples. Both list and non-list parameters are in the unittest.
Codecov Report
@@ Coverage Diff @@
## devel #748 +/- ##
==========================================
+ Coverage 33.91% 34.40% +0.49%
==========================================
Files 93 93
Lines 16562 16770 +208
==========================================
+ Hits 5617 5770 +153
- Misses 10945 11000 +55
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I just explain why it's designed to be a list. Once I had three Slurm clusters, and tens of DP-GEN projects. So I want to make sure that DP-GEN submits its tasks to the most available (having most empty nodes or shortest waiting queue), and implement some detective functions in dispatcher. But it seems no one except me has this need, and so when we upgrade to dpdispatcher this function is deprecated.
* supports non-list mdata The mdata of a task is a list of a single dict. This "list" looks useless and not clear enough. So this commit supports using the dict without a list. Note that old parameters are still supported, so no breaking changes are made. The "list" is just removed from all examples. Both list and non-list parameters are in the unittest. * fix typo
The mdata of a task is a list of a single dict. This "list" looks useless and not clear enough. So this commit supports using the dict without a list.
Note that old parameters are still supported, so no breaking changes are made. The "list" is just removed from all examples. Both list and non-list parameters are in the unit test.
Old parameter:
New parameter: