Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

args: trust level for model_devi_job should be optional #818

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jul 23, 2022

The arguments #786 added should be optional.

@njzjz
Copy link
Member Author

njzjz commented Jul 23, 2022

@Cloudac7

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022

Codecov Report

Merging #818 (832f3ae) into devel (deff833) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel     #818   +/-   ##
=======================================
  Coverage   35.13%   35.13%           
=======================================
  Files          96       96           
  Lines       16808    16808           
=======================================
  Hits         5905     5905           
  Misses      10903    10903           
Impacted Files Coverage Δ
dpgen/generator/arginfo.py 45.37% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deff833...832f3ae. Read the comment docs.

@wanghan-iapcm wanghan-iapcm merged commit 0eb2098 into deepmodeling:devel Jul 24, 2022
@Cloudac7
Copy link
Contributor

With now dargs based argument checking, it raise dargs.dargs.ArgumentKeyError due to lack of model_devi_f_trust_lo when setting local model_devi_f_trust_lo. Should Optional be set to True for model_devi_f_trust_lo in model_devi_lmp_args?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants