Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

args: remove duplicated argument #839

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 3, 2022

I don't notice it's duplicated in #829 but the unit test in #821 has thrown errors.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #839 (78bdf33) into devel (5a57de2) will increase coverage by 0.77%.
The diff coverage is 62.54%.

@@            Coverage Diff             @@
##            devel     #839      +/-   ##
==========================================
+ Coverage   35.16%   35.93%   +0.77%     
==========================================
  Files          96       97       +1     
  Lines       16817    17094     +277     
==========================================
+ Hits         5913     6143     +230     
- Misses      10904    10951      +47     
Impacted Files Coverage Δ
dpgen/auto_test/common_prop.py 38.15% <40.00%> (-0.10%) ⬇️
dpgen/auto_test/Gamma.py 61.13% <61.13%> (ø)
dpgen/auto_test/Lammps.py 30.94% <100.00%> (ø)
dpgen/generator/arginfo.py 99.20% <100.00%> (+50.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit b8b2ce8 into deepmodeling:devel Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants