add tests to check machine files #874
Conversation
njzjz
requested review from
HuangJiameng,
hongriTianqi,
felix5572 and
wanghan-iapcm
|
@HuangJiameng, @hongriTianqi, @felix5572: I modified some of the machine files you just added to make the tests pass. |
| } | ||
| } | ||
| }, | ||
| "resources": { | ||
| "local_root":"./", | ||
| "batch_type": "Lebesgue", |
There was a problem hiding this comment.
Why delete "local_root", and add "batch_type"? Shouldn't "batch_type" be added in "machine" block?
There was a problem hiding this comment.
I don't see why you added local_root. It's never a parameter of resources.
There was a problem hiding this comment.
batch_type is used for checking as different types have different parameters.
There was a problem hiding this comment.
I don't see why you added
local_root. It's never a parameter ofresources.
This machine.json file was obtained from dpgen users in AISI, local_root was set from the very beginning. I will check with them.
There was a problem hiding this comment.
batch_typeis used for checking as different types have different parameters.
batch_type has been set in the machine block, is it necessary to repeat this information in resources block?
There was a problem hiding this comment.
@y1xiaoc do you think it is possible to use an argument in another block as the variant key?
There was a problem hiding this comment.
@y1xiaoc do you think it is possible to use an argument in another block as the variant key?
In principle yes but I may need to redesign current dargs code structure. Are these two keys always have to be the same? Currently one way to enforce that is to set the extra_check parameter in their comment parent argument.
No description provided.