Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move some imports into runtime functions #894

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 20, 2022

gromacswrapper throws lots of warnings. boto3 may cause critical errors. We move these imports into the runtime functions.

Fix #674.

gromacswrapper throws lots of warnings. boto3 may cause critical errors. We move these imports into the runtime functions.

Fix deepmodeling#674.
@njzjz njzjz linked an issue Aug 20, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #894 (72f5873) into devel (180c3b4) will decrease coverage by 0.01%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##            devel     #894      +/-   ##
==========================================
- Coverage   38.14%   38.13%   -0.02%     
==========================================
  Files          99       99              
  Lines       17766    17764       -2     
==========================================
- Hits         6777     6774       -3     
- Misses      10989    10990       +1     
Impacted Files Coverage Δ
dpgen/dispatcher/AWS.py 25.26% <14.28%> (-2.87%) ⬇️
dpgen/generator/run.py 62.53% <50.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AnguseZhang AnguseZhang merged commit 5bb5561 into deepmodeling:devel Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] boto3 raise an exception if not configure aws region.
4 participants