-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter 'srtab_file_path' so that one can use DP-ZBL potential successfully #918
Conversation
Signed-off-by: Chenqqian Zhang <100290172+Chengqian-Zhang@users.noreply.github.com>
Codecov ReportBase: 39.48% // Head: 39.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #918 +/- ##
=======================================
Coverage 39.48% 39.49%
=======================================
Files 99 99
Lines 17989 17998 +9
=======================================
+ Hits 7103 7108 +5
- Misses 10886 10890 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
please edit the title of the PR to make it informative. |
I have completed that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the parameter to arginfo.py
.
Signed-off-by: Chenqqian Zhang <100290172+Chengqian-Zhang@users.noreply.github.com>
Signed-off-by: Chenqqian Zhang <100290172+Chengqian-Zhang@users.noreply.github.com>
|
the conflict should be resolved. |
Signed-off-by: Chenqqian Zhang <100290172+Chengqian-Zhang@users.noreply.github.com>
|
I have modified the code and resolved the conflict . Please check. |
I have modified the code according to your suggestions, please review again. |
Signed-off-by: Chenqqian Zhang 100290172+Chengqian-Zhang@users.noreply.github.com
Now there is a problem, if someone wants to use zbl potential, the energy table will not be copied into the task folder with input.json, I added a new parameter "srtab_file_path" , the user needs to write the path of the energy table, when generating the training task, this file will be copied into the task folder.