Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize autotest document based on #891 #923

Merged
merged 18 commits into from
Sep 2, 2022

Conversation

HuangJiameng
Copy link
Collaborator

@HuangJiameng HuangJiameng commented Aug 27, 2022

yato0422 and others added 12 commits August 19, 2022 09:36
add the explanation of autotest

Signed-off-by: yato0422 <73833089+yato0422@users.noreply.github.com>
Signed-off-by: yato0422 <73833089+yato0422@users.noreply.github.com>
Signed-off-by: yato0422 <73833089+yato0422@users.noreply.github.com>
Signed-off-by: yato0422 <73833089+yato0422@users.noreply.github.com>
Signed-off-by: yato0422 <73833089+yato0422@users.noreply.github.com>
merge dev_hujunwei to autotest_wiki2website
- fix contents according to comments in deepmodeling#891
- reorganize the document structure
@HuangJiameng HuangJiameng changed the title optimize autotest document based on optimize autotest document based on #891 Aug 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #923 (0fa9c0d) into devel (4cb8550) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel     #923      +/-   ##
==========================================
- Coverage   38.21%   38.14%   -0.07%     
==========================================
  Files          99       99              
  Lines       17819    17883      +64     
==========================================
+ Hits         6809     6821      +12     
- Misses      11010    11062      +52     
Impacted Files Coverage Δ
dpgen/generator/lib/lammps.py 61.07% <0.00%> (-11.52%) ⬇️
dpgen/dispatcher/AWS.py 25.26% <0.00%> (-2.87%) ⬇️
dpgen/data/surf.py 66.46% <0.00%> (-0.87%) ⬇️
dpgen/generator/run.py 61.92% <0.00%> (-0.22%) ⬇️
dpgen/generator/arginfo.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amcadmus
Copy link
Member

@HuangJiameng do you want to replace #891 by this PR? If so I will close #891

@HuangJiameng
Copy link
Collaborator Author

@HuangJiameng do you want to replace #891 by this PR? If so I will close #891

Yes. Thanks.

doc/autotest/property/properties/Surface-make.md Outdated Show resolved Hide resolved
doc/autotest/property/properties/Surface-make.md Outdated Show resolved Hide resolved
doc/autotest/property/properties/Interstitial-make.md Outdated Show resolved Hide resolved
doc/autotest/property/properties/Interstitial-make.md Outdated Show resolved Hide resolved
doc/autotest/property/properties/Elastic-make.md Outdated Show resolved Hide resolved
doc/autotest/property/properties/Vacancy-make.md Outdated Show resolved Hide resolved
doc/autotest/property/properties/Vacancy-make.md Outdated Show resolved Hide resolved
@njzjz
Copy link
Member

njzjz commented Aug 29, 2022

It looks like the links are still unavailable.

@HuangJiameng
Copy link
Collaborator Author

It looks like the links are still unavailable.

Hmm... They work well when I check them.

@njzjz
Copy link
Member

njzjz commented Aug 29, 2022

It looks like the links are still unavailable.

Hmm... They work well when I check them.

Oh, I was wrong.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/autotest/property/properties/EOS-make.md Outdated Show resolved Hide resolved
doc/autotest/property/properties/EOS-post.md Show resolved Hide resolved
doc/autotest/property/properties/Elastic-make.md Outdated Show resolved Hide resolved
doc/autotest/property/properties/EOS-make.md Outdated Show resolved Hide resolved
doc/autotest/property/properties/Surface-make.md Outdated Show resolved Hide resolved
doc/autotest/relaxation/Relaxation-make.md Outdated Show resolved Hide resolved
- remove parameter 'static-opt'
- changed the default values for lammps minimize to 0 and 1e-10.
- make the examples for each property consistent with Property-get-started-and-examples.md
- move the results in Property-post.md to each property's example for post
@@ -24,4 +24,4 @@ Equation of State (EOS) here calculates the energies of the most stable structur
}
```

`vol_start` is the starting volume per atom in Å^3/atom, `vol_step` is the increasing step of volume, and the biggest volume is smaller than `vol_end`. In the above example, 40 tasks would be generated as `task.000000` to `task.000020` with from 0.9 to 1.1 times the volume of equilibrium structure (Å^3/atom as the unit), respectively.
`vol_start` is the starting relative volume per atom in Å^3/atom, `vol_step` is the increasing step of the ratio of relative volume, and the biggest volume is smaller than `vol_end` times the volume of equilibrium structure.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this:

vol_start is the starting volume relative to the equilibrium structure, vol_step is the volume increment step relative to the equilibrium structure, and the biggest relative volume is smaller than vol_end.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghan-iapcm wanghan-iapcm merged commit 8964171 into deepmodeling:devel Sep 2, 2022
@HuangJiameng HuangJiameng deleted the autotest_wiki2website branch September 26, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants