Supplementary unittests for merge_traj function to detect issue #957 #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 39.42% // Head: 39.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #961 +/- ##
==========================================
+ Coverage 39.42% 39.48% +0.05%
==========================================
Files 99 99
Lines 17979 17989 +10
==========================================
+ Hits 7089 7103 +14
+ Misses 10890 10886 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I think #958 can be replaced by this pr. @HuangJiameng |
njzjz
reviewed
Sep 21, 2022
Chengqian-Zhang
force-pushed
the
merge_traj_test
branch
from
256c4ae to
09f07e5
Compare
njzjz
approved these changes
Dec 2, 2022
HuangJiameng
approved these changes
Dec 3, 2022
AnguseZhang
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added unittest is to check that the process of extracting the configuration from model_devi.out to generate the first principles calculation task is correct.
When issue #957 exists:
When issue #957 is solved: