Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify: support list for pick_data #994

Merged
merged 2 commits into from
Nov 25, 2022
Merged

simplify: support list for pick_data #994

merged 2 commits into from
Nov 25, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 12, 2022

No description provided.

@njzjz njzjz requested a review from wanghan-iapcm October 14, 2022 00:12
wanghan-iapcm
wanghan-iapcm reviewed Nov 25, 2022
View reviewed changes
Copy link
Contributor

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to confirm that the convention used for pick_data is exactly the same as init_data_sys

@njzjz
Copy link
Member Author

njzjz commented Nov 25, 2022

Generally speaking, yes, but I remember that init_data_sys cannot be an absolute path.

@wanghan-iapcm wanghan-iapcm merged commit eab1825 into deepmodeling:devel Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghan-iapcm wanghan-iapcm wanghan-iapcm left review comments

@HuangJiameng HuangJiameng HuangJiameng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njzjz @wanghan-iapcm @HuangJiameng