ci(wheel): enable linux aarch64 wheel #2216
Conversation
WalkthroughThe update enhances the GitHub Actions workflow by introducing a new job, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2216 +/- ##
==========================================
- Coverage 95.51% 95.23% -0.28%
==========================================
Files 19 18 -1
Lines 1471 1448 -23
==========================================
- Hits 1405 1379 -26
- Misses 66 69 +3 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| determine-arm64-runner: | ||
| runs-on: ubuntu-latest | ||
| permissions: read-all | ||
| outputs: | ||
| runner: ${{ steps.set-runner.outputs.runner }} | ||
| steps: | ||
| - name: Determine which runner to use for ARM64 build | ||
| id: set-runner | ||
| run: | | ||
| if [ "${{ github.repository_owner }}" == "deepmodeling" ]; then | ||
| echo "runner=[\"Linux\",\"ARM64\"]" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "runner=\"ubuntu-latest\"" >> $GITHUB_OUTPUT | ||
| fi |
There was a problem hiding this comment.
Consider using a more maintainable approach for setting the runner output.
- echo "runner=[\"Linux\",\"ARM64\"]" >> $GITHUB_OUTPUT
- echo "runner=\"ubuntu-latest\"" >> $GITHUB_OUTPUT
+ echo "::set-output name=runner::${{ github.repository_owner == 'deepmodeling' ? '[\"Linux\",\"ARM64\"]' : 'ubuntu-latest' }}"This change uses GitHub Actions' native set-output command, which is more maintainable and less error-prone than appending to $GITHUB_OUTPUT.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| determine-arm64-runner: | |
| runs-on: ubuntu-latest | |
| permissions: read-all | |
| outputs: | |
| runner: ${{ steps.set-runner.outputs.runner }} | |
| steps: | |
| - name: Determine which runner to use for ARM64 build | |
| id: set-runner | |
| run: | | |
| if [ "${{ github.repository_owner }}" == "deepmodeling" ]; then | |
| echo "runner=[\"Linux\",\"ARM64\"]" >> $GITHUB_OUTPUT | |
| else | |
| echo "runner=\"ubuntu-latest\"" >> $GITHUB_OUTPUT | |
| fi | |
| determine-arm64-runner: | |
| runs-on: ubuntu-latest | |
| permissions: read-all | |
| outputs: | |
| runner: ${{ steps.set-runner.outputs.runner }} | |
| steps: | |
| - name: Determine which runner to use for ARM64 build | |
| id: set-runner | |
| run: | | |
| echo "::set-output name=runner::${{ github.repository_owner == 'deepmodeling' ? '[\"Linux\",\"ARM64\"]' : 'ubuntu-latest' }}" |
njzjz
changed the title
CodSpeed Performance ReportMerging #2216 will not alter performanceComparing Summary
|
Summary by CodeRabbit