-
Notifications
You must be signed in to change notification settings - Fork 1
chore: prepare for npm release under @deepnote org #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
39f58bc
724d352
3cba2ea
926eb92
16582f6
59b26e4
e79fe2a
790b558
5edc247
1fe1629
0cc057e
b399b86
74ef8ba
282ed50
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,16 @@ const config = { | |
| }, | ||
| }, | ||
| testEnvironment: 'jsdom', | ||
| moduleNameMapper: { | ||
| '^slate$': '<rootDir>/packages/slate/src', | ||
| '^slate-history$': '<rootDir>/packages/slate-history/src', | ||
| '^slate-hyperscript$': '<rootDir>/packages/slate-hyperscript/src', | ||
| '^slate-react$': '<rootDir>/packages/slate-react/src', | ||
| '^@deepnote/slate$': '<rootDir>/packages/slate/src', | ||
| '^@deepnote/slate-history$': '<rootDir>/packages/slate-history/src', | ||
| '^@deepnote/slate-hyperscript$': '<rootDir>/packages/slate-hyperscript/src', | ||
| '^@deepnote/slate-react$': '<rootDir>/packages/slate-react/src', | ||
| }, | ||
|
Comment on lines
+10
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Module mappings support dual package names during migration—consider future cleanup. The moduleNameMapper correctly aliases both unscoped (e.g., However, the configuration duplicates mappings for the same packages. If this is meant to be temporary during the migration, add a comment noting that unscoped imports should be phased out and the corresponding mappings removed once the migration is complete. // Temporary dual mappings for migration from unscoped to @deepnote/* scoped packages.
// Once all imports are updated to use @deepnote/* names, remove the unscoped mappings below.
moduleNameMapper: {
// TODO: Remove unscoped mappings post-migration
'^slate$': '<rootDir>/packages/slate/src',
'^slate-history$': '<rootDir>/packages/slate-history/src',
'^slate-hyperscript$': '<rootDir>/packages/slate-hyperscript/src',
'^slate-react$': '<rootDir>/packages/slate-react/src',
// Scoped mappings (canonical)
'^@deepnote/slate$': '<rootDir>/packages/slate/src',
'^@deepnote/slate-history$': '<rootDir>/packages/slate-history/src',
'^@deepnote/slate-hyperscript$': '<rootDir>/packages/slate-hyperscript/src',
'^@deepnote/slate-react$': '<rootDir>/packages/slate-react/src',
},🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| module.exports = config | ||
Uh oh!
There was an error while loading. Please reload this page.